search

fastify / fastify-type-provider-typebox

A Type Provider for Typebox
MIT License
154 stars 27 forks source link

chore: update TypeBox highest version #162

Closed nickfla1 closed 3 months ago

nickfla1 commented 3 months ago

Fixes #161

Updates the highest TypeBox version to <= 0.33.x

Checklist

nickfla1 commented 3 months ago

The CI fails with

Attempting to download 14... Not found in manifest. Falling back to download directly from Node Error: Unable to find Node version '14' for platform darwin and architecture arm64.

I don't think it's related to this PR. Is still supporting node 14 a requirement for this package?

gurgunday commented 3 months ago

Oh, I thought you were targeting main

This issue is about node 14 (and 16?) on macos

We should exclude them from the workflow

nickfla1 commented 3 months ago

Oh, I thought you were targeting main

I targeted the current active version, I thought then we could forward port it. Let me know if you prefer the other way around, I'll rebase!

We should exclude them from the workflow

Shall I do it in this PR? I can open a new on to fix this problem first

gurgunday commented 3 months ago

Shall I do it in this PR? I can open a new on to fix this problem first

Please! A new PR to v4 branch like this one would be appreciated

You can see an example here of the exclusions I'm talking about: https://github.com/fastify/workflows/blob/28dd54c988abaceeb5df90ab1d7e21ad30a96e92/.github/workflows/plugins-ci.yml#L108-L114

I targeted the current active version, I thought then we could forward port it. Let me know if you prefer the other way around, I'll rebase!

It's not crucial but backporting can be more straightforward with git cherry-pick

nickfla1 commented 3 months ago

Please! A new PR to v4 branch like this one would be appreciated

Fixed in https://github.com/fastify/fastify-type-provider-typebox/pull/163

It's not crucial but backporting can be more straightforward with git cherry-pick

I have noticed that main removes peerDependecies altogether and already adds 0.32.0 to the test variants

gurgunday commented 3 months ago

Yeah but after another look, I think there's an issue with main — I overlooked the custom CI that was present and replaced it with the generic fastify/workflows CI, which will actually prevent the typebox tests from being run

I'll revert that

gurgunday commented 3 months ago

Can you pull from v4? It should be good now

nickfla1 commented 3 months ago

Looks like everything's good now!

gurgunday commented 3 months ago

Alright, so the CI is fixed on main, can you target it now with the same changes?

nickfla1 commented 3 months ago

Updated!