fix(hmr): fix hmr when using h2 and use merge config

fastify / fastify-vite

Fastify plugin for Vite integration.

MIT License

849 stars 71 forks source link

fix(hmr): fix hmr when using h2 and use merge config #110

Closed benatshippabo closed 1 year ago

benatshippabo commented 1 year ago

Description

Sets vite hmr server to use fastify. This fixes #109 and will allow users to use https and h2 with @fastify/vite. Also uses mergeConfig and defineConfig for hassle free recursive config merging and type safe config declarations.

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

benatshippabo commented 1 year ago

@galvez there is a task to run the benchmark, but I don't see benchmark listed as a script in the package.json.

galvez commented 1 year ago

Thank you! Let me run the test suite and I'll merge and release this.

galvez commented 1 year ago

@galvez there is a task to run the benchmark, but I don't see benchmark listed as a script in the package.json.

Yeah, that needs some maintenance work.

benatshippabo commented 1 year ago

@galvez any feedback for this pull request? Please let me know if anything needs to be adjusted

galvez commented 1 year ago

Hey there — I should push out a new release with this by Monday. Thank you!