If vites config contains `defineConfig` with callback, then SSR is broken

PredokMiF commented 1 year ago

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the bug has not already been reported

4.17.0

4.0.0

16.18.1

Windows

10 Pro (21H2)

In vite.config.js I need to generate config for different goals. vite can help with this case and front build is Ok, but when I start http-server with the plugin - it fails, cause in next code https://github.com/fastify/fastify-vite/blob/568e178a10768211944bfc1aaf6e57a6a091693d/packages/fastify-vite/config.js#L173 we try to make Object.assign(<function>, <object>), where <function> is config-function from vite.config.js

Get any react SSR example (not SPA) like https://github.com/fastify/fastify-vite/tree/dev/examples/react-hydration
Open vite.config.js

Modify export like this

import { defineConfig } from 'vite'
//...
export default defineConfig((config) => {
return ({ root, plugins })
})

No issue

galvez commented 1 year ago

Think this is already fixed, need to add a test and push out the new release. Will double check.

PredokMiF commented 1 year ago

This is great news because this bug breaks my build and I had to add a lot of hacks. I'm really looking forward to the release.

PredokMiF commented 1 year ago

In which branch can I see the fixed code?

fastify / fastify-vite