fix: await userConfig to support async vite config

fastify / fastify-vite

Fastify plugin for Vite integration.

MIT License

849 stars 71 forks source link

fix: await userConfig to support async vite config #120

Closed felixmosh closed 9 months ago

felixmosh commented 9 months ago

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

closes #119

felixmosh commented 9 months ago

I can't run tests locally, it breaks on this

Uzlopak commented 9 months ago

I realize that this repo does not have any tests. Nevermind. I guess @galvez will manually review it.

felixmosh commented 9 months ago

The alternative is "not working" lib :]

galvez commented 9 months ago

I realize that this repo does not have any tests.

Perhaps I should highlight this in the README — the tests are in the package folder and also in every individual example, which further help validate if the package is working as expected.

Uzlopak commented 9 months ago

@galvez We need a CI/CD pipeline.

galvez commented 9 months ago

@galvez We need a CI/CD pipeline.

That's for sure — will look into that as soon as I can!