search

fastify / fastify-vite

Fastify plugin for Vite integration.
MIT License
849 stars 71 forks source link

feat: add more types #127

Closed Gehbt closed 8 months ago

Gehbt commented 8 months ago

Description

just for title, firstly reference config.js.

Checklist

netlify[bot] commented 8 months ago

Deploy Preview for agitated-mahavira-26f8f9 canceled.

Name Link
Latest commit 405ad871eceda3d257b3c5d2a16a37fcabf0fb6b
Latest deploy log https://app.netlify.com/sites/agitated-mahavira-26f8f9/deploys/6586611d131f930008e80ec2
galvez commented 8 months ago

That's amazing, thank you! I'm pinging my buddy @micheleriva who knows a lot more TypeScript than I do for an extra pair of eyes.

Gehbt commented 8 months ago

It would be great if I could help you. And maybe I should add some test-suit?

galvez commented 8 months ago

Documentation definitely needs some expansion into what's available in the route context, server-side, these new types will help a lot with that. The reason I haven't merged is that I don't consider myself knowledgeable enough to review, so that's why I'm waiting on an additional review — but it certainly looks good to me. Surely if you can find opportunities to test these (I have no idea how one goes about testing types), that would be great.

Really appreciate the work!