fastify / fastify-vite

Fastify plugin for Vite integration.
MIT License
879 stars 73 forks source link

revert(fastify-vite): fix(fastify-vite): file path formats on Windows… #141

Closed Shyam-Chen closed 7 months ago

Shyam-Chen commented 7 months ago

… (#138)

Description

The issue arises from the injected path.

https://github.com/fastify/fastify-vite/blob/dev/packages/fastify-react/virtual/routes.js#L5 https://github.com/fastify/fastify-vite/blob/dev/packages/fastify-vue/virtual/routes.js#L3

My bad. At that time, I made some changes to the path, and the execution seemed feasible.

I'm attempting to avoid using root: join(dirname(path), 'client'),.

Checklist

netlify[bot] commented 7 months ago

Deploy Preview for agitated-mahavira-26f8f9 canceled.

Name Link
Latest commit 0fa84faea4fe9a1dca26ebd0af7009fc17f62dd7
Latest deploy log https://app.netlify.com/sites/agitated-mahavira-26f8f9/deploys/65e6e33da7904800072aaf52
galvez commented 7 months ago

Hey @Shyam-Chen is this just a revert or does it include a fix? Do we still need to look into that Windows bug?

Shyam-Chen commented 7 months ago

@galvez Not include a fix. Yes.