Add #injectWS - Githubissues

fastify / fastify-websocket

basic websocket support for fastify

MIT License

394 stars 72 forks source link

Closed DanieleFedeli closed 6 months ago

DanieleFedeli commented 10 months ago

Now is possible to invoke an websocket handler without listening.

closes #35

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

DanieleFedeli commented 10 months ago

Can I have some CI love? on my MacOS latest with node 20 it is passing

DanieleFedeli commented 10 months ago

Can someone approve the workflow to run?

mcollina commented 10 months ago

Seems CI is failing

DanieleFedeli commented 9 months ago

DanieleFedeli commented 9 months ago

I can see that the issue linked has no activity, I will change my implementation to use mock-socket as @airhorns suggested.

DanieleFedeli commented 7 months ago

https://github.com/mafintosh/stream-shift/issues/6 looks solved. I ran all the tests locally for node 21. The pipeline now should pass.

DanieleFedeli commented 6 months ago

Is there something I can do to make this mergeable?

mcollina commented 6 months ago

Nothing, me shipping it!