Update for Fastify v5 - Githubissues

fastify / fastify-websocket

basic websocket support for fastify

MIT License

394 stars 72 forks source link

Update for Fastify v5 #293

Closed synapse closed 4 months ago

synapse commented 6 months ago

Ref: https://github.com/fastify/fastify/issues/5116

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

gurgunday commented 6 months ago

Ok, will start merging now, but just for consistency, I've so far kept the .taprc files and haven't moved tap options to package.json as so far we've preferred explicit config files

So it would be great if you could keep .taprc, thanks

https://github.com/fastify/fastify-cookie/blob/next/.taprc https://github.com/fastify/fastify-rate-limit/blob/next/.taprc

mcollina commented 5 months ago

CI is failing

gurgunday commented 4 months ago

Hey @synapse sorry for this, but master had a breaking change and it requires some refactoring, do you have time to take a look?