Closed erming closed 3 years ago
LGTM.
For reference for other reviewers: https://eta.js.org/docs/api/configuration
Could you add a test like this one to verify this new default value? https://github.com/fastify/point-of-view/blob/f218d2eaaec32a76ddbf43bac4edb6b79c6011d1/test/test-eta.js#L803
Done!
Hello maintainers,
While using this plugin with the https://github.com/eta-dev/eta template engine, I noticed that
NODE_ENV=production
never cached the templates.After some digging I found the culprit:
point-of-view
never sends the{ cache: true }
option to theeta
engineThis pull request solves this.
It can also be enabled by passing
production: true
to the engine.Benchmark
Rendering a simple template with
NODE_ENV=production
Performance improvements:
Checklist
npm run test