Closed multivoltage closed 1 year ago
@mcollina maybe I should have created a special issue for this change?
why?
Honestly I don't know. Is my second time I submit a pr ;)
I have issue, this PR doesn't work if eta using includeFile.
Please open a new detailed issue adding a Minimal, Reproducible Example.
Checklist
npm run test
andnpm run benchmark
Goal
I want etajs@3.x support for this project. Hope my PR or other people want same feature
What I did not
Not edited documentation since probably I cannot say to be skilled enough in this project
What I did
I tried to make all the tests work by changing as few things as possible. Unfortunately, one big change involves creating an Eta instance with new Eta(). I had to change many parts of the tests. Not sure about many changes. Finally I started a test project by installing fastify, and linking index.js. I managed to get the basic example working: