Closed multivoltage closed 6 months ago
In my small experience I prefer only await and async instead callback. But there are some case where we cannot wait a "line" but only start a "parallel" method. I will do an analysis next day.
If we agree to replace all callback with await async, do you you think I can put changes in that pr ?
It's better to do the two things separately
Ok. I will try to use callback for this or. Thanks
@mcollina when you say to migrate all codebase to async await you are considering also for example readFile() or only calls "then()" for promises?
All of it, yes.
I resume this PR since async flow was introduced
CLosing for no activity
OK. I updated PR (like I said in the previous comment). Did you expect other changes?
Checklist
npm run test
andnpm run benchmark
Goal
I saw an issue of an user that ask support for html-minifier-terser in place of html-minifier. Only thing that change is that minify method is a promise.
Behavior using old html-minifier
Since in js we can do
Even point-of-view will add the terser version which is Promise based, configuring options like this:
can be done also using html-minifier instead html-minifier-terser