chore(.prettierignore): add

fastify / point-of-view

Template rendering plugin for Fastify

MIT License

335 stars 86 forks source link

chore(.prettierignore): add #406

Closed mweberxyz closed 5 months ago

mweberxyz commented 5 months ago

Add .prettierignore to avoid making a mess

Checklist

[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

mweberxyz commented 5 months ago

See https://github.com/fastify/fastify/pull/2269 and particularly https://github.com/fastify/fastify/pull/2269#issuecomment-773981605

prettier makes a mess of this repo when enabled, and both core and other plugins have this file for consistency

Uzlopak commented 5 months ago

Usually we decide such changes centralized in the skeleton repo and then apply it to all our repos for uniformity and order. Master of the Order is @Fdawgs

Please open a corresponding PR in https://github.com/fastify/skeleton

mweberxyz commented 5 months ago

https://github.com/fastify/skeleton/pull/53 created and this PR updated to be the exact change suggested there.

Uzlopak commented 5 months ago

I saw that. Just be a little bit patient. We are compared to other teams relatively fast. Expect that we decide this through in about a week.

mweberxyz commented 5 months ago

No rush! Just added the link in this PR for future context.

Uzlopak commented 5 months ago

Please also add the change in the eslintrc file as you did in skeleton