search

fastify / point-of-view

Template rendering plugin for Fastify
MIT License
341 stars 86 forks source link

chore: add benchmark PR workflow #408

Closed mweberxyz closed 6 months ago

mweberxyz commented 7 months ago

Adds the shared plugins-benchmark-pr.yml workflow to PRs.

Usage

Add the benchmark tag to a PR in order to run benchmarks and compare against master.

Example

https://github.com/mweberxyz/point-of-view/pull/2

Checklist

mweberxyz commented 7 months ago

Changing to draft state - I would like to make a few changes to make the output more useful to what is requested in a typical PR conversation.

Uzlopak commented 7 months ago

@mweberxyz There is a bug in the benchmark flow.

can you take care of it please?

https://github.com/fastify/workflows/issues/93

mweberxyz commented 7 months ago

Leaving this draft for a little bit longer to see if there's any feedback on https://github.com/fastify/workflows/issues/121, otherwise will return and go forward as is.

mweberxyz commented 6 months ago

Turns out automating statistically significant, actionable benchmarks are easier said than done. Still spending time poking, but closing for now.