Fix support for submodules

fastify / pre-commit

Fork of https://github.com/observing/pre-commit

MIT License

9 stars 5 forks source link

Fix support for submodules #55

Closed mohd-akram closed 2 years ago

mohd-akram commented 2 years ago

Closes #15

Checklist

[x] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

mohd-akram commented 2 years ago

Not sure how to go about this...there don't seem to be any tests for the install script.

mohd-akram commented 2 years ago

Any update on this?

jsumners commented 2 years ago

I'd like to see a test. An integration test is acceptable.

Uzlopak commented 2 years ago

@mohd-akram

Dont get me wrong: Did you close this because you dont want to provide a test?

mohd-akram commented 2 years ago

This is not that big of a priority for me, and I'm not currently using this fork (I'm using the original pre-commit module but that isn't maintained). Someone has to figure out how to add install tests to the repo and integrate it with the CI.