Closed nimesh0505 closed 1 month ago
Do we need c8 or can we use the built-in coverage? https://nodejs.org/api/test.html#collecting-code-coverage
Do we need c8 or can we use the built-in coverage? https://nodejs.org/api/test.html#collecting-code-coverage
@simoneb Thanks for suggesting the use of Node.js's built-in coverage. After consideration, I think we should stick with c8 for now. Here's why:
--experimental-test-coverage
flag is still experimental, which could lead to instability or changes in future Node.js versions.@fastify/pre-commit
should prioritize stability for its users.However, I agree it's a good idea to eventually move to the built-in coverage. I suggest we:
experimental
prefix).This way, we maintain stability for our users while staying prepared to adopt the built-in solution when it's ready. What do you think?
Sounds good, I brought it up in case other maintainers have an opinion on this
Use c8 for now.
This PR replaces tap with node:test and introduces c8 for code coverage.
Checklist
npm run test
andnpm run benchmark