Improve performance - Githubissues

fastify / proxy-addr

Determine address of proxied request (fork)

MIT License

6 stars 3 forks source link

Open Uzlopak opened 1 year ago

Uzlopak commented 1 year ago

Currently working on the performance of this package.

There are still some perf gains to get.

[ ] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message and code follows the Developer's Certification of Origin and the Code of conduct

mcollina commented 1 year ago

Note that we are not using this module in Fastify right now, but we switched back to upstream.

I'm ok to switch again if this gives an improvement.

Uzlopak commented 1 year ago

The thing is that we have already improvements because our forwarded fork is significantly faster. https://github.com/fastify/forwarded/pull/41

So we should have switched long time ago. :D

I am currently working on improving the performance for checking if the ip is trustable.

mcollina commented 1 year ago

Can you make the switch again?

Uzlopak commented 1 year ago

sry, I have to investigate something.