fastify / send

Fork of the send module to deal with CVE-2017-20165
MIT License
13 stars 11 forks source link

Folder name with emoji causes compression errors. #78

Open Niranjan-A-S opened 1 week ago

Niranjan-A-S commented 1 week ago

Prerequisites

Fastify version

4.28.0

Plugin version

No response

Node.js version

20.14

Operating system

Windows

Operating system version (i.e. 20.04, 11.3, 10)

10

Description

The emoji "☃" in the "test/fixtures/snow ☃" is causing issues while trying to compress the node_modules of the application using the window's native compress tool.

Link to code that reproduces the bug

No response

Expected Behavior

No response

mcollina commented 1 week ago

Thanks for reporting!

Can you provide steps to reproduce? We often need a reproducible example, e.g. some code that allows someone else to recreate your problem by just copying and pasting it. If it involves more than a couple of different file, create a new repository on GitHub and add a link to that.

Niranjan-A-S commented 1 week ago

Please follow the steps to reproduce.

Screenshot 2024-07-09 153619

Eomm commented 1 week ago

Duplicate https://github.com/fastify/send/issues/51 ?

I mean, save time by ignoring test/ folders

Niranjan-A-S commented 1 week ago

Requires an extra layer of step to remove the test folder during the build process. The "snow ☃" can be renamed right?

jsumners commented 1 week ago

Requires an extra layer of step to remove the test folder during the build process. The "snow ☃" can be renamed right?

No. https://github.com/fastify/send/commit/8a44fe6f117ba947647ed16d8a6696cef9fdafb8

Niranjan-A-S commented 1 week ago

Great!