Typescript types for SessionStore Promise based API support

fastify / session

Session plugin for fastify

Other

96 stars 44 forks source link

Typescript types for SessionStore Promise based API support #237

Open jonaskello opened 4 months ago

jonaskello commented 4 months ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

In #78 the SessionStore was upgraded to support both callback and Promise based API. However this is not reflected in the current typescript types. I propose that the typescript types are updated to reflect the changes in #78.

Motivation

Typescript users could use Promise.

Example

No response

mcollina commented 4 months ago

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests. We use tsd for types