fastify / website

https://fastify.dev/
MIT License
60 stars 63 forks source link

Added 'Getting Started' button and started improving homepage style #164

Open Giovym opened 1 year ago

Giovym commented 1 year ago

Description

This pull request introduces two main changes:

  1. Added "Getting Started" and "Learn More" buttons to the homepage that provides quick access to the "Getting Started" section and to the new Resources page.
  2. Made style improvements to the homepage.

I've opened this pull request to address a specific aspect of issue #133, which is the improvement of the "Getting Started" navigation, while also initiating the process of modernizing the homepage's style. I'm also open to different ideas and approaches for implementing these changes.

Related Issues

Partially addresses [#133]

mcollina commented 1 year ago

I think the text and logo size is too small.

Screenshot 2023-10-19 at 10 09 12

jsumners commented 1 year ago

I think the text and logo size is too small.

The banner in that screenshot is huge. I much prefer the smaller banner on the current site. In my opinion, the focus should be on content, not a header.

Giovym commented 1 year ago

I think the text and logo size is too small.

Thank you for your feedback. Yes, this happens because I used 'vh' as a unit of measurement for the height, so if we zoom out the page, the header still occupies half of the height. To fix it, I will remove this unit of measurement and set the height back to its original value.

Giovym commented 1 year ago

Ok, it was just a suggestion. The main change in this pull request was the addition of the two buttons for quick access to the "Getting Started" and "Resources" pages. No problem, let's go back to the current image.

Giovym commented 1 year ago

ops

It seems that when I fixed the width for the two buttons to make them the same size, I have forgotten about these other two. I'll correct this issue. Additionally, I want to add a media query to adjust the spacing between the two buttons for smartphone users.