Open AndreAngelantoni opened 3 weeks ago
Yes, will do.
On Sun, Oct 6, 2024 at 9:38 AM Manuel Spigolon @.***> wrote:
@.**** commented on this pull request.
Could you run the linter to get a green run&deploy?
/home/runner/work/website/website/src/theme/DocPage/index.js Error: 79:10 error 'LatestVersionSuggestionLabel' is defined but never used no-unused-vars
— Reply to this email directly, view it on GitHub https://github.com/fastify/website/pull/252#pullrequestreview-2350556289, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE3WQBIPSKUN2RRWDSPNNIDZ2FKPFAVCNFSM6AAAAABPMRL5QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJQGU2TMMRYHE . You are receiving this because you authored the thread.Message ID: @.***>
Not part of our PR...sorry, couldn't tell you.
On Wed, Oct 9, 2024 at 1:45 PM Aras Abbasi @.***> wrote:
@.**** commented on this pull request.
In src/theme/DocVersionBanner/index.js https://github.com/fastify/website/pull/252#discussion_r1794138464:
@@ -0,0 +1,126 @@ +/**
Why is that facebook copyright?
— Reply to this email directly, view it on GitHub https://github.com/fastify/website/pull/252#pullrequestreview-2358169946, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE3WQBJWSB5D5NIRDGTCUVLZ2WBWHAVCNFSM6AAAAABPMRL5QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJYGE3DSOJUGY . You are receiving this because you authored the thread.Message ID: @.***>
@AndreAngelantoni it's 100% part of your PR.
Ok, I'll look into it.
On Thu, Oct 10, 2024 at 1:40 AM Matteo Collina @.***> wrote:
@AndreAngelantoni https://github.com/AndreAngelantoni it's 100% part of your PR.
— Reply to this email directly, view it on GitHub https://github.com/fastify/website/pull/252#issuecomment-2404315276, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE3WQBMXEN63I3EHOIOGCYDZ2YVODAVCNFSM6AAAAABPMRL5QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUGMYTKMRXGY . You are receiving this because you were mentioned.Message ID: @.***>
My apologies, I thought that was for something else.
That was added by the Swizzler tool and has now been removed. Looking into the HTML detritus next.
I'm seeing this extra HTML in the current production docs: https://fastify.dev/docs/latest/Reference/LTS/
I can certainly remove it as part of this PR but perhaps someone had intentions for it? (This is what I thought the other comment was referring to. Again, my apologies.)
My apologies...I thought the comment was referring to something else.
That was added by the Swizzler tool and it's now gone.
On Thu, Oct 10, 2024 at 7:02 AM André Angelantoni @.***> wrote:
Ok, I'll look into it.
On Thu, Oct 10, 2024 at 1:40 AM Matteo Collina @.***> wrote:
@AndreAngelantoni https://github.com/AndreAngelantoni it's 100% part of your PR.
— Reply to this email directly, view it on GitHub https://github.com/fastify/website/pull/252#issuecomment-2404315276, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE3WQBMXEN63I3EHOIOGCYDZ2YVODAVCNFSM6AAAAABPMRL5QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUGMYTKMRXGY . You are receiving this because you were mentioned.Message ID: @.***>
The banner should not be shown for v4, which is still supported. Looks good otherwise.
Modification made. Please confirm.
Description
This PR does the following:
The banners seemed to require swizzling the existing pages. If that wasn't correct, please advise.
Related Issues
Addresses https://github.com/fastify/fastify/issues/5623.
Check List