fastify / website

https://fastify.dev/
MIT License
60 stars 59 forks source link

Dev experience #46

Open Eomm opened 1 year ago

Eomm commented 1 year ago

We must work to improve the dev experience before working on this website takes days to run and build.

The issues to solve are:

jonnydgreen commented 1 year ago

I'll load up the website locally and report back if I think of any suggestions :)

AugustinMauroy commented 1 year ago

Should we use typescript (tsx)?

AugustinMauroy commented 1 year ago

I can't launch the project locally. It should be enough to do an npm install then npm start.

AugustinMauroy commented 1 year ago

What do you think about creating a slack channel to discuss the project?

Eomm commented 1 year ago

What do you think about creating a slack channel to discuss the project?

we can create a discord one - will do later today

I can't launch the project locally

Please, read the readme and run npm run build:website too. of course, this is one of the parts we need to improve 😄

Eomm commented 1 year ago

I have created the discord channel: https://discord.com/channels/725613461949906985/1067900422376935504

AugustinMauroy commented 1 year ago

@Eomm I can't access follow this https://support.discord.com/hc/en-us/articles/204155938-How-do-I-invite-friends-to-my-server-

Eomm commented 1 year ago

You can find it in the main fastify repo https://discord.gg/fastify

aradwann commented 1 year ago
Eomm commented 1 year ago

When I opened the repo in Vscode locally, the colors changed, I think it is too vibrant for me

Here my statement https://github.com/fastify/website-next/pull/60#pullrequestreview-1270560143 TLDR: Yes, remove it and send a PR, but I think the suggested plugins are useful

I wonder if there could another way other than installing GitHub CLI to run the website locally.

Yes, but we need someone to replace it with bash scripting + we will need another GitHub token. the client is handy because it deals with it without annoying the dev IMHO

metcoder95 commented 1 year ago

Sadly I've never contributed to the website repo, but my take from the comments it seems that we are mostly lacking portability to be able to run the project easily in locally.

Is there anything else do you think is missed or requires re-work?

msbn21 commented 1 year ago

@Eomm, I am trying to launch the website locally on my machine, I am following the instructions provided in fastify/website repo to launch the website locally, however npm start command keeps complaining about missing static/generated/benchmarks.json file while running docusaurus start, can someone please help me with this ?

Eomm commented 1 year ago

What is the output of npm run build:website? What is your system?

msbn21 commented 1 year ago

I am using a mac, when i run npm run build:website it downloads the releases and then it throws this error node:internal/process/promises:289 triggerUncaughtException(err, true /* fromPromise */); ^

Error: Client network socket disconnected before secure TLS connection was established at connResetException (node:internal/errors:720:14) at TLSSocket.onConnectEnd (node:_tls_wrap:1682:19) at TLSSocket.emit (node:events:524:35) at endReadableNT (node:internal/streams/readable:1378:12) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { code: 'ECONNRESET', path: undefined, host: 'raw.githubusercontent.com', port: 443, localAddress: null }

And then it fails with error [ERROR] Error: Missing generated file: static/generated/benchmarks.json. Run the "npm run build:website" once.

Eomm commented 1 year ago

It seems an error connecting to github. are you logged in with your cli? could you add all the output? it help us to understand which step of the process blocks you

msbn21 commented 1 year ago

Yes, it was github connectivity indeed. I have logged in but the connection was somehow not getting established, i am able to launch the application now. Please let me know if there are any immediate tasks which i can take up and start contributing.

Eomm commented 1 year ago

I would start from this one: https://github.com/fastify/website/issues/131

No idea here - but you can add be creative!