fastify / workflows

Reusable workflows for use in the Fastify organization
MIT License
11 stars 8 forks source link

chore: add reusable plugin workflow #1

Closed Fdawgs closed 2 years ago

Fdawgs commented 2 years ago

Created a basic reusable GitHub Action workflow that can be used across all of the plugins in the Fastify org.

Also integrates changes to coveralls actions as mentioned in https://github.com/fastify/fastify/issues/3328, and the latest fastify/github-action-merge-dependabot version.

Checklist

climba03003 commented 2 years ago

Should we remove node@10 and wait until fastify@4 for the reusable workflow integration?

Fdawgs commented 2 years ago

Would you mind using two-space tag instead of 4 spaces on the yml files?

The 4 space style is due to me using Prettier for a lot of my stuff. Standard, which seems to be the main style in the Fastify org, doesn't seem to support yml formatting.

I don't know if we need to decide on a standard format for yml and other file types?

Eomm commented 2 years ago

Yes, standard is used to check js files. I don't think that we need a yml files

I'm suggesting the 2 spaces because it fits better on mobile gh app when there is no pc at disposal, and to copy-cat the standard style as well

Fdawgs commented 2 years ago

Yes, standard is used to check js files. I don't think that we need a yml files

I'm suggesting the 2 spaces because it fits better on mobile gh app when there is no pc at disposal, and to copy-cat the standard style as well

Cool beans, will take a pass at it on Monday when back in work.

Fdawgs commented 2 years ago

Yes, standard is used to check js files. I don't think that we need a yml files I'm suggesting the 2 spaces because it fits better on mobile gh app when there is no pc at disposal, and to copy-cat the standard style as well

Cool beans, will take a pass at it on Monday when back in work.

Resolved by https://github.com/fastify/workflows/pull/1/commits/bc2a4f6c704c0de950f6d2a610e9a9f1e20fa772