fastify / workflows

Reusable workflows for use in the Fastify organization
MIT License
9 stars 6 forks source link

Updates for fastify v5 #107

Closed nrayburn-tech closed 10 months ago

nrayburn-tech commented 10 months ago

Drop node <= 16 from workflows Add node 21 to benchmark-pr Add node 21 to ci-package-manager for yarn

Fixes #106, #92.

Checklist

jsumners commented 10 months ago

The v4 tag has been created.

mcollina commented 10 months ago

Let's hope this does not get auto-updated across the entire fleet, otherwise it would be a nightmare to revert.

jsumners commented 10 months ago

It shouldn't. But what in the actual eff Dependabot? https://github.com/fastify/releasify/pull/283

@Fdawgs I believe you have setup the majority of the Dependabot stuff. Do you know why it would automatically update the major versions of workflows?

Fdawgs commented 10 months ago

https://github.com/fastify/github-action-merge-dependabot working as intended.

mcollina commented 10 months ago

@Fdawgs would this land automatically then?

Fdawgs commented 10 months ago

@Fdawgs would this land automatically then?

Unfortunately, yes. Can see it making its way through all the reps now. 😵‍💫

jsumners commented 10 months ago

We really should not be updating at least our own workflows's major version automatically. The whole point of the versioning, particularly in this repo, is to indicate breaking changes in the workflow.

jsumners commented 10 months ago

How do we stop the linked tool from updating all of our repos automatically for this?

jsumners commented 10 months ago

@nrayburn-tech I have removed the v4 tag for right now. To continue your work, use the git SHA. I will restore the v4 tag once we have fixed the above discussed problem.