fastify / workflows

Reusable workflows for use in the Fastify organization
MIT License
9 stars 6 forks source link

Either a v4 tag or branch should be created or the README should be updated #123

Closed 10xLaCroixDrinker closed 5 months ago

10xLaCroixDrinker commented 5 months ago

Prerequisites

Issue

The README says to use @v4, but this does not exist.

jobs:
  ci:
    uses: fastify/workflows/.github/workflows/plugins-ci.yml@v4

See this failing run on fastify-flash for reference

https://github.com/fastify/fastify-flash/actions/runs/7835351308/workflow

Check failure on line 20 in .github/workflows/ci.yml

GitHub Actions
/ .github/workflows/ci.yml
Invalid workflow file
error parsing called workflow
".github/workflows/ci.yml"
-> "fastify/workflows/.github/workflows/plugins-ci.yml@v4"
: failed to fetch workflow: reference to workflow should be either a valid branch, tag, or commit
gurgunday commented 5 months ago

Context: we can’t release v4 (which is for Fastify v5) for the moment because Dependabot starts automatically updating every single repo

For now, we use full version numbers like v4.1.0

10xLaCroixDrinker commented 5 months ago

Thanks for the context @gurgunday. Would a PR to make the README reflect that be welcome?

jsumners commented 5 months ago

Time is better spent getting Fastify v5 ready and shipped, and/or fixing the dependabot problem. It should not automatically update workflows with new major versions of this workflow.