search

fastify / workflows

Reusable workflows for use in the Fastify organization
MIT License
10 stars 7 forks source link

Make node versions dynamic #124

Closed gurgunday closed 5 months ago

gurgunday commented 5 months ago

This will let us use the centralized workflow for most libraries

Examples of where it will be used if merged:

https://github.com/fastify/proxy-addr/pull/61#pullrequestreview-2003940510 https://github.com/fastify/fluent-json-schema/pull/242 https://github.com/fastify/process-warning/pull/104

and other @fastify/libraries repos

gurgunday commented 5 months ago

Should package managers be tested cross platform?

Fdawgs commented 5 months ago

Should package managers be tested cross platform?

Probably leave those on Ubuntu only as well, so they match what the main Fastify repo is doing. :)

If you could update the readme with the new option as well then this PR'll be good to go!

gurgunday commented 5 months ago

Done, let me know if the README could be improved

gurgunday commented 5 months ago

Just reverted an unnecessary change to benchmark

815aca9f00ba4da2502550b5adb1afc18752fc5b