search

fastify / workflows

Reusable workflows for use in the Fastify organization
MIT License
9 stars 6 forks source link

package.json version on main #125

Closed gurgunday closed 4 months ago

gurgunday commented 4 months ago

Prerequisites

Issue

For workflows we only do releases, but we haven't so far touched the version on package.json and it still shows the version as 3 instead of 4, in fact it's even behind the v3.y.z branch

Should we update that before releasing v4.2.0? Note that the branch v3.y.z is where the 3 line lives

@Fdawgs

gurgunday commented 4 months ago

I actually don't know why there is even a package.json here

Fdawgs commented 4 months ago

It should be updated when running the release workflow, it's just that the recent releases went out without running that:

https://github.com/fastify/workflows/blob/main/CONTRIBUTING.md#release-process

gurgunday commented 4 months ago

Oh I see, but it says if we do that v4 will be created, which we don't want

gurgunday commented 4 months ago

Thanks!