fastify / workflows

Reusable workflows for use in the Fastify organization
MIT License
9 stars 6 forks source link

chore: exclude Node 14 and 16 on macos #127

Closed simoneb closed 4 months ago

simoneb commented 4 months ago

Related to https://github.com/fastify/.github/issues/37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

Checklist

mcollina commented 4 months ago

yes

simoneb commented 4 months ago

Folks feel free to push to this branch, I was only intending to capture the way to do it

mcollina commented 4 months ago

I'm not entirely comfortable in shipping this change myself, because there is a bit of automation here that I know nothing about (I think). If somebody familiar can ship, it would unblock a few PRs that are currently failing everywhere.

gurgunday commented 4 months ago

I'll do it, just need a second to clone

gurgunday commented 4 months ago

It needs to be applied to the rest of the workflows in this repo, does it not?

Everything else runs only on ubuntu, because services already require it like you said, so we should be good, no?

I'm not entirely comfortable in shipping this change myself, because there is a bit of automation here that I know nothing about (I think). If somebody familiar can ship, it would unblock a few PRs that are currently failing everywhere.

We just tag a new version from main for now, without using the workflow

Then we should cherry pick to v3.y.z branch and tag a separate release for it

gurgunday commented 4 months ago

I’ll backport it to v3 now