Closed simoneb closed 4 months ago
yes
Folks feel free to push to this branch, I was only intending to capture the way to do it
I'm not entirely comfortable in shipping this change myself, because there is a bit of automation here that I know nothing about (I think). If somebody familiar can ship, it would unblock a few PRs that are currently failing everywhere.
I'll do it, just need a second to clone
It needs to be applied to the rest of the workflows in this repo, does it not?
Everything else runs only on ubuntu, because services already require it like you said, so we should be good, no?
I'm not entirely comfortable in shipping this change myself, because there is a bit of automation here that I know nothing about (I think). If somebody familiar can ship, it would unblock a few PRs that are currently failing everywhere.
We just tag a new version from main for now, without using the workflow
Then we should cherry pick to v3.y.z
branch and tag a separate release for it
I’ll backport it to v3 now
Related to https://github.com/fastify/.github/issues/37.
This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations
Checklist
npm run test
andnpm run benchmark