fastify / workflows

Reusable workflows for use in the Fastify organization
MIT License
9 stars 6 forks source link

benchmark workflow broken #93

Closed Uzlopak closed 6 months ago

Uzlopak commented 1 year ago

Prerequisites

Issue

It seems that github.event.pull_request.head.repo.full_name is potentially incorrect. maybe it has to be github.event.pull_request.base.repo.full_name.

Eomm commented 1 year ago

There should be both fields: https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request

mweberxyz commented 6 months ago

I believe I understand the issue, taking https://github.com/fastify/point-of-view/pull/408 as an example, the filtered pull_request payload is:

CleanShot 2024-02-20 at 14 18 12@2x

But 408 is merging from mweberxyz/point-of-view fork into fastify/point-of-view, so the second actions/checkout@v4 should use the base instead -- so that the benchmarks run from fastify/pov#master, instead of mweberxyz/pov#master

@Uzlopak is that the gist of it?

Uzlopak commented 6 months ago

@mweberxyz

I think your assessment is right.