search

fastio / 1store

NoSQL data store using the SEASTAR framework, compatible with Redis
GNU Affero General Public License v3.0
1.32k stars 170 forks source link

compile pedis error #26

Closed tracymacding closed 6 years ago

tracymacding commented 6 years ago

[3/4] CXX build/release/commit_log.o FAILED: build/release/commit_log.o /opt/scylladb/bin/g++ -MD -MT build/release/commit_log.o -MF build/release/commit_log.o.d -std=gnu++17 -g -Wall -Werror -Wno-error=deprecated-declarations -fvisibility=hidden -Wno-attributes -pthread -I/u01/jeff.dk/github/pedis/seastar -U_FORTIFY_SOURCE -march=nehalem -fconcepts -I/u01/jeff.dk/github/pedis/seastar/fmt/include -DBOOST_TEST_DYN_LINK -Wno-ignored-attributes -Wno-overloaded-virtual -Wno-maybe-uninitialized -Wno-error=cpp -Wno-stringop-overflow -DSEASTAR_HAVE_GCC6_CONCEPTS -DSEASTAR_NO_EXCEPTION_HACK -DNO_EXCEPTION_INTERCEPT -DSEASTAR_HAVE_HWLOC -DSEASTAR_HAVE_NUMA -DSEASTAR_HAVE_LZ4_COMPRESS_DEFAULT -O2 -I/u01/jeff.dk/github/pedis/seastar/build/release/gen -I/u01/jeff.dk/github/pedis/seastar/build/release/c-ares -I/usr/include/jsoncpp -DBOOST_TEST_DYN_LINK -Wno-maybe-uninitialized -Wno-tautological-compare -Wno-missing-braces -Wno-error=deprecated-declarations -DHAVE_LIBSYSTEMD=1 -I. -I build/release/gen -I seastar -I seastar/build/release/gen -c -o build/release/commit_log.o commit_log.cc commit_log.cc: In function ‘void store::init_type_crc(uint32_t*)’: commit_log.cc:98:21: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (int i = 0; i <= MAX_RECORD_TYPE; i++) { ^~~~ cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed

dorlaor commented 6 years ago

Looks like a minor bug to me, patch is welcomed

On Tue, Nov 6, 2018 at 10:46 PM Kai Ding notifications@github.com wrote:

[3/4] CXX build/release/commit_log.o FAILED: build/release/commit_log.o /opt/scylladb/bin/g++ -MD -MT build/release/commit_log.o -MF build/release/commit_log.o.d -std=gnu++17 -g -Wall -Werror -Wno-error=deprecated-declarations -fvisibility=hidden -Wno-attributes -pthread -I/u01/jeff.dk/github/pedis/seastar -U_FORTIFY_SOURCE -march=nehalem -fconcepts -I/u01/jeff.dk/github/pedis/seastar/fmt/include -DBOOST_TEST_DYN_LINK -Wno-ignored-attributes -Wno-overloaded-virtual -Wno-maybe-uninitialized -Wno-error=cpp -Wno-stringop-overflow -DSEASTAR_HAVE_GCC6_CONCEPTS -DSEASTAR_NO_EXCEPTION_HACK -DNO_EXCEPTION_INTERCEPT -DSEASTAR_HAVE_HWLOC -DSEASTAR_HAVE_NUMA -DSEASTAR_HAVE_LZ4_COMPRESS_DEFAULT -O2 -I/u01/ jeff.dk/github/pedis/seastar/build/release/gen -I/u01/ jeff.dk/github/pedis/seastar/build/release/c-ares -I/usr/include/jsoncpp -DBOOST_TEST_DYN_LINK -Wno-maybe-uninitialized -Wno-tautological-compare -Wno-missing-braces -Wno-error=deprecated-declarations -DHAVE_LIBSYSTEMD=1 -I. -I build/release/gen -I seastar -I seastar/build/release/gen -c -o build/release/commit_log.o commit_log.cc commit_log.cc: In function ‘void store::init_type_crc(uint32_t*)’: commit_log.cc:98:21: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (int i = 0; i <= MAX_RECORD_TYPE; i++) { ^~~~ cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fastio/pedis/issues/26, or mute the thread https://github.com/notifications/unsubscribe-auth/ABp6RT55mlXyvtcWPOyaAMbcuUUPI4SHks5usoHVgaJpZM4YR3py .

tracymacding commented 6 years ago

Looks like a minor bug to me, patch is welcomed … On Tue, Nov 6, 2018 at 10:46 PM Kai Ding @.**> wrote: [3/4] CXX build/release/commit_log.o FAILED: build/release/commit_log.o /opt/scylladb/bin/g++ -MD -MT build/release/commit_log.o -MF build/release/commit_log.o.d -std=gnu++17 -g -Wall -Werror -Wno-error=deprecated-declarations -fvisibility=hidden -Wno-attributes -pthread -I/u01/jeff.dk/github/pedis/seastar -U_FORTIFY_SOURCE -march=nehalem -fconcepts -I/u01/jeff.dk/github/pedis/seastar/fmt/include -DBOOST_TEST_DYN_LINK -Wno-ignored-attributes -Wno-overloaded-virtual -Wno-maybe-uninitialized -Wno-error=cpp -Wno-stringop-overflow -DSEASTAR_HAVE_GCC6_CONCEPTS -DSEASTAR_NO_EXCEPTION_HACK -DNO_EXCEPTION_INTERCEPT -DSEASTAR_HAVE_HWLOC -DSEASTAR_HAVE_NUMA -DSEASTAR_HAVE_LZ4_COMPRESS_DEFAULT -O2 -I/u01/ jeff.dk/github/pedis/seastar/build/release/gen -I/u01/ jeff.dk/github/pedis/seastar/build/release/c-ares -I/usr/include/jsoncpp -DBOOST_TEST_DYN_LINK -Wno-maybe-uninitialized -Wno-tautological-compare -Wno-missing-braces -Wno-error=deprecated-declarations -DHAVE_LIBSYSTEMD=1 -I. -I build/release/gen -I seastar -I seastar/build/release/gen -c -o build/release/commit_log.o commit_log.cc commit_log.cc: In function ‘void store::init_type_crc(uint32_t)’: commit_log.cc:98:21: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (int i = 0; i <= MAX_RECORD_TYPE; i++) { ^~~~ cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABp6RT55mlXyvtcWPOyaAMbcuUUPI4SHks5usoHVgaJpZM4YR3py .

I will fix it later

tracymacding commented 6 years ago

Looks like a minor bug to me, patch is welcomed … On Tue, Nov 6, 2018 at 10:46 PM Kai Ding @.**> wrote: [3/4] CXX build/release/commit_log.o FAILED: build/release/commit_log.o /opt/scylladb/bin/g++ -MD -MT build/release/commit_log.o -MF build/release/commit_log.o.d -std=gnu++17 -g -Wall -Werror -Wno-error=deprecated-declarations -fvisibility=hidden -Wno-attributes -pthread -I/u01/jeff.dk/github/pedis/seastar -U_FORTIFY_SOURCE -march=nehalem -fconcepts -I/u01/jeff.dk/github/pedis/seastar/fmt/include -DBOOST_TEST_DYN_LINK -Wno-ignored-attributes -Wno-overloaded-virtual -Wno-maybe-uninitialized -Wno-error=cpp -Wno-stringop-overflow -DSEASTAR_HAVE_GCC6_CONCEPTS -DSEASTAR_NO_EXCEPTION_HACK -DNO_EXCEPTION_INTERCEPT -DSEASTAR_HAVE_HWLOC -DSEASTAR_HAVE_NUMA -DSEASTAR_HAVE_LZ4_COMPRESS_DEFAULT -O2 -I/u01/ jeff.dk/github/pedis/seastar/build/release/gen -I/u01/ jeff.dk/github/pedis/seastar/build/release/c-ares -I/usr/include/jsoncpp -DBOOST_TEST_DYN_LINK -Wno-maybe-uninitialized -Wno-tautological-compare -Wno-missing-braces -Wno-error=deprecated-declarations -DHAVE_LIBSYSTEMD=1 -I. -I build/release/gen -I seastar -I seastar/build/release/gen -c -o build/release/commit_log.o commit_log.cc commit_log.cc: In function ‘void store::init_type_crc(uint32_t)’: commit_log.cc:98:21: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (int i = 0; i <= MAX_RECORD_TYPE; i++) { ^~~~ cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABp6RT55mlXyvtcWPOyaAMbcuUUPI4SHks5usoHVgaJpZM4YR3py .

i have made a pr, see https://github.com/fastio/pedis/pull/27