fastlane-community / fastlane-plugin-applivery

fastlane plugin to upload IPA or APK to Applivery.com
https://www.applivery.com/
MIT License
12 stars 7 forks source link

Error in build when the commit message starts with "@" #6

Closed pedroamador closed 6 years ago

pedroamador commented 7 years ago

/var/lib/gems/2.3.0/gems/fastlane-2.56.0/fastlane_core/lib/fastlane_core/ui/interface.rb:143:in `shell_error!': [!] Exit status of command 'curl "https://dashboard.applivery.com/api/builds" -H "Authorization: xxxxxx" -F app="xxxxxx" -F versionName="xxxxx" -F notes="Uploaded automatically with fastlane plugin" -F notify=true -F autoremove=true -F os=android -F tags="" -F deployer=fastlane -F package=@"/myApp/app/build/outputs/apk/app.apk" -F gitBranch="develop" -F gitCommit="xxxxx (FastlaneCore::Interface::FastlaneShellError) " -F gitMessage="@ie fastlane Staging" -F gitRepositoryURL="xxxx "' was 26 instead of 0. % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (26) couldn't open file "ie fastlane Staging"

pedroamador commented 7 years ago

The commit message start exactly with "@ie fastlane xxxxx"

Alesete commented 7 years ago

Seems like is not escaping special characters for the git message

@CesarTrigo maybe we should send the message percent encoded?

CesarTrigo commented 6 years ago

Selected for development To be done:

pedroamador commented 6 years ago

It's the normal behaviour of "curl" when you call it from command line, at least in linux systems where I was tested it. If you run with

curl "@test"

then you get the same result as if you run with

curl @"test"

In this example the "curl" command interprets the "test" parameter as a file, whatever you place the "at" symbol within the quotes or before (outside) the quotes.