search

fastlane-community / fastlane-plugin-applivery

fastlane plugin to upload IPA or APK to Applivery.com
https://www.applivery.com/
MIT License
12 stars 7 forks source link

[Fastlane plugin] Action does not fail if curl command fails #7

Closed ndonald2 closed 4 years ago

ndonald2 commented 5 years ago

The way the plugin is currently implemented, the action will not fail if the curl upload command fails. For example, if the build path is invalid and there is no file to upload, the upload API returns a failure code but the action silently ignores it and the lane succeeds. This is not helpful when using the action in CI/CD as it gives a false sense of success; the failure can only be detected by looking into the logs.

Alesete commented 4 years ago

Hi @ndonald2 We've just released a new version (v2.1.0) using Faraday instead of curl. Now we are able to manage the Applivery's response and also we are exposing a new SharedValue::APPLIVERY_BUILD_ID

Thanks!

CesarTrigo commented 4 years ago

Consider it fixed in v2.1.0.