fastlane-community / fastlane-plugin-cordova_screenshots

Take screenshots of your Cordova/Ionic app with fastlane
MIT License
17 stars 10 forks source link

Config paths should be parameters #18

Open osrl opened 5 years ago

osrl commented 5 years ago

I wanted to put config files to a different folder. I had to override CordovaScreenshots::CORDOVA_SCREENSHOTS_IOS_CONFIG_PATH from a lane as a workaround for now.

janpio commented 5 years ago

Interesting - what's the use case behind that? Why not fastlane/cordova_screenshots/ios?

(For reference: https://github.com/ionic-zone/fastlane-plugin-cordova_screenshots/blob/master/lib/fastlane/plugin/cordova_screenshots/constants.rb)

osrl commented 5 years ago

I'm using different config files not related to cordova. I've put them to fastlane/config_files. I didn't want to create a different folder for cordova screenshots. That's not a priority though.

janpio commented 5 years ago

Ok, that makes sense - having the folder structure to be configurable is a good thing. I don't like the folder structure fastlane dictates by itself as well.

You could just CordovaScreenshots::CORDOVA_SCREENSHOTS_IOS_CONFIG_PATH = 'fastlane/config_files' in your lane to achieve what you wanted?

osrl commented 5 years ago

Yes I've already done that for a workaround for now. Thanks 👍

janpio commented 5 years ago

(I actually just wanted to confirm that I understood your initial message correctly and that this is possible ;) Confirmed :D )