search

fastlane-community / fastlane-plugin-ionic

Integrate your Ionic build into your Fastlane setup
MIT License
87 stars 46 forks source link

Remove/rename/reevaluate `CORDOVA` environment variables #2

Open janpio opened 6 years ago

janpio commented 6 years ago

This would maybe clash with the cordova plugin - or maybe not. Have to see what I do with these.

janpio commented 6 years ago

It does when both plugins are installed at the same time:

/Users/sujan/.rvm/gems/ruby-2.4.1/gems/fastlane-plugin-cordova-0.3.4/lib/fastlane/plugin/cordova/actions/cordova_action.rb:4: warning: already initialized constant Fastlane::Actions::SharedValues::CORDOVA_IOS_RELEASE_BUILD_PATH
/Users/sujan/.rvm/gems/ruby-2.4.1/gems/fastlane-plugin-ionic-0.3.4/lib/fastlane/plugin/ionic/actions/ionic_action.rb:4: warning: previous definition of CORDOVA_IOS_RELEASE_BUILD_PATH was here
/Users/sujan/.rvm/gems/ruby-2.4.1/gems/fastlane-plugin-cordova-0.3.4/lib/fastlane/plugin/cordova/actions/cordova_action.rb:5: warning: already initialized constant Fastlane::Actions::SharedValues::CORDOVA_ANDROID_RELEASE_BUILD_PATH
/Users/sujan/.rvm/gems/ruby-2.4.1/gems/fastlane-plugin-ionic-0.3.4/lib/fastlane/plugin/ionic/actions/ionic_action.rb:5: warning: previous definition of CORDOVA_ANDROID_RELEASE_BUILD_PATH was here

or 

/Users/sujan/fastlane-plugin-ionic/lib/fastlane/plugin/ionic/actions/ionic_action.rb:4: warning: already initialized constant Fastlane::Actions::SharedValues::CORDOVA_IOS_RELEASE_BUILD_PATH
/Users/sujan/.rvm/gems/ruby-2.4.1/gems/fastlane-plugin-cordova-0.3.4/lib/fastlane/plugin/cordova/actions/cordova_action.rb:4: warning: previous definition of CORDOVA_IOS_RELEASE_BUILD_PATH was here
/Users/sujan/fastlane-plugin-ionic/lib/fastlane/plugin/ionic/actions/ionic_action.rb:5: warning: already initialized constant Fastlane::Actions::SharedValues::CORDOVA_ANDROID_RELEASE_BUILD_PATH
/Users/sujan/.rvm/gems/ruby-2.4.1/gems/fastlane-plugin-cordova-0.3.4/lib/fastlane/plugin/cordova/actions/cordova_action.rb:5: warning: previous definition of CORDOVA_ANDROID_RELEASE_BUILD_PATH was here