Fix build_number parameter description

fastlane-community / fastlane-plugin-ionic

Integrate your Ionic build into your Fastlane setup

MIT License

86 stars 45 forks source link

Fix build_number parameter description #35

Closed isair closed 5 years ago

isair commented 5 years ago

The parameter affects the version code on Android as well. However, the description mentions that the parameter only works for iOS.

janpio commented 5 years ago

Hm, does it really?

There is some special handling code for iOS that uses this param: https://github.com/ionic-zone/fastlane-plugin-ionic/blob/59f895897ea6cde2e339746b6698403fd279f5b9/lib/fastlane/plugin/ionic/actions/ionic_action.rb#L94-L104

But maybe also for Android because of https://github.com/ionic-zone/fastlane-plugin-ionic/blob/59f895897ea6cde2e339746b6698403fd279f5b9/lib/fastlane/plugin/ionic/actions/ionic_action.rb#L16!?

Did you test this @isair?

isair commented 5 years ago

Yes, build_number gets mapped to versionCode and is passed correctly to the ionic cordova compile command via the android_args variable. Tested successfully.