search

fastlane-community / fastlane-plugin-ionic

Integrate your Ionic build into your Fastlane setup
MIT License
86 stars 45 forks source link

feat: Use locally installed Ionic (from `node_modules/.bin`) #58

Open brunobastosg opened 4 years ago

brunobastosg commented 4 years ago

In my company we have a couple of Mac Minis that are used for building iOS apps in CI.

It's common for projects to have different Ionic and/or Cordova versions, so using the globally installed Ionic is no good in this case.

janpio commented 4 years ago

Thanks, this is a great feature.

Is node_modules/.bin valid on all platforms?

I think we had similar requests in the past to be able to use npx ionic or something like that, your PR should be a good template to implement that as well.

brunobastosg commented 4 years ago

Thanks, this is a great feature.

Is node_modules/.bin valid on all platforms?

I think we had similar requests in the past to be able to use npx ionic or something like that, your PR should be a good template to implement that as well.

I know node_modules/.bin is valid on Linux & Mac OS. I'll have to test it on Windows, but it's gonna take a few days.

brunobastosg commented 4 years ago

I replaced node_modules/.bin with File.join("node_modules", ".bin", "") (so it uses the correct path separators), but I couldn't get Fastlane to work on Windows (some problem while installing gem unf_ext).

I'm using Chocolatey to install Ruby and installed all these packages below, but nothing seems to work.

7zip.commandline 16.02.0.20170209
7zip.portable 19.0
chocolatey 0.10.15
chocolatey-core.extension 1.3.3
DotNet4.5.2 4.5.2.20140902
microsoft-visual-cpp-build-tools 14.0.25420.1
mingw 8.1.0
msys2 20180531.0.0
nodejs.install 10.16.2
ruby 2.5.3.101
ruby2.devkit 4.7.2.2013022403
robingenz commented 4 years ago

node_modules/.bin is also valid on windows. It would be great to see this feature in fastlane.

Are there any updates?

brunobastosg commented 4 years ago

@robingenz I couldn't test in on Windows, but if you're saying it works, it's up to @janpio to merge or not.