search

fastlane-community / fastlane-plugin-ionic

Integrate your Ionic build into your Fastlane setup
MIT License
87 stars 46 forks source link

Create equivalent for GRADLE_APK_OUTPUT_PATH #7

Open janpio opened 6 years ago

janpio commented 6 years ago

Something like this can be used when you built before with gradle:

    supply(
      track: "alpha",
      apk: "#{lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH]}"
    )

This variable is also used by other actions automatically: https://github.com/fastlane/fastlane/blob/3ce48e60491805749f9b95b11e159376777fe688/fastlane/lib/fastlane/actions/supply.rb#L15

So having something like this called IONIC_APK_OUTPUT_PATH and IONIC_IOS_OUTPUT_PATH could be useful for use.

janpio commented 6 years ago

Code for it is here: https://github.com/fastlane/fastlane/blob/e4d14b0da65d15d2bc44bc0c5aea2722cbe21957/fastlane/lib/fastlane/actions/gradle.rb#L67-L69

janpio commented 6 years ago

Oh nice, fastlane-plugin-cordova alread does this, so we are doing this:

ENV['CORDOVA_ANDROID_RELEASE_BUILD_PATH'] = "./platforms/android/build/outputs/apk/android-#{build_type}.apk" ENV['CORDOVA_IOS_RELEASE_BUILD_PATH'] = "./platforms/ios/build/device/#{app_name}.

https://github.com/bamlab/fastlane-plugin-cordova/blob/4f3ef89b0fdca6ce344ba6322d148dfe37541c0e/lib/fastlane/plugin/cordova/actions/cordova_action.rb#L100-L101

Neat.

janpio commented 6 years ago

Ok seems to be buggy right now: https://github.com/bamlab/fastlane-plugin-cordova/issues/7