search

fastlane-community / fastlane-plugin-s3

fastlane plugin to upload IPA or APK to AWS S3 by @joshdholtz
MIT License
146 stars 65 forks source link

aws-sdk version bump to v3 #72

Closed jaximan closed 4 years ago

jaximan commented 5 years ago

Resolves #71.

jackyLianMT commented 4 years ago

Please merge this pr as the fastlane 2.144 has swtiched to aws-sdk v3. Having this plugin on v2 leads to a dependency conflict issue

 fastlane-plugin-aws_s3 was resolved to 1.6.1, which depends on
      aws-sdk (~> 2.3) was resolved to 2.3.0, which depends on
        aws-sdk-resources (= 2.3.0) was resolved to 2.3.0, which depends on
          aws-sdk-core (= 2.3.0)

    fastlane (~> 2.144) was resolved to 2.144.0, which depends on
      aws-sdk-s3 (~> 1.0) was resolved to 1.61.1, which depends on
        aws-sdk-core (~> 3, >= 3.83.0)
jaximan commented 4 years ago

@jackyLianMT I can rebase PR with latest master, but still looking for reviewer :(

levibostian commented 4 years ago

@jaximan, I have a new PR made here to do what you have done with this PR. I am pointing this out if you want to avoid having to rebase.

joshdholtz commented 4 years ago

Closing this since this was completed in #81 when fastlane also changed to using v3. Thanks for the PR thought! ❤️