fastlane-community / xcov

Nice code coverage reporting without hassle
MIT License
556 stars 107 forks source link

Ignoring folders doesn't work #94

Closed robertofrontado closed 7 years ago

robertofrontado commented 7 years ago

This is my setup:

Fastfile

desc "Coveralls"
lane :coveralls do
  xcov(
    project: "Project.xcodeproj",
    scheme: ENV["BITRISE_SCHEME"],
    coveralls_repo_token: ENV["COVERAGE_ACCESS_TOKEN"],
    ignore_file_path: "./.xcovignore"
  )  
end

.xcovignore

# .xcovignore.yml

# Ignore files
- PROJECT/folder/
- PROJECT/folder/*
- PROJECT/folder/*.swift

Is not ignoring the files at that folder, is that right? Or I'm doing it wrong

kohtenko commented 7 years ago

Same here. None of the options below work for me:

Pods
Pods/
Pods/*
robertofrontado commented 7 years ago

Yep I had to ignore every file 😞

kohtenko commented 7 years ago

Looking into the source code I can see that ignoring actually works well. Files that I wanted to ignore weren't listed in terminal during the execution because they don't added to the target. So coverage calculated without them even if they aren't in .xcovignore. Don't know about your case though, @robertofrontado.

nakiostudio commented 7 years ago

Hi @robertofrontado @kohtenko :wave:

Thanks for reporting! I'm digging into this right now 👍

nakiostudio commented 7 years ago

Can't reproduce the issue, the only thing that works funny is how the path to the .xcovignore file is set by default.

This is my .xcovignore file:

- Example/
- EasyPeasy/

And this is the result:

screen shot 2017-07-15 at 13 17 50 screen shot 2017-07-15 at 13 18 17
robertofrontado commented 7 years ago

@nakiostudio Strange thing, I tested it today again and using - Pods it worked 🤔

So, I'll close this issue and reopen it again if needed 👍