search

fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command
https://fastlane.tools
2.24k stars 162 forks source link

Deliver fails after iTunes connect updated yesterday (9/24) #337

Closed kani-rifluxyss closed 9 years ago

kani-rifluxyss commented 9 years ago

Deliver fails after iTunes connect updated yesterday (9/24)

We are using deliver for few months now, so far working good. Thanks for making this tool.

Yesterday Apple updated their UI for itunesconnect and deliver is failing.

Is there an update available to handle this?

Here is what it says:

App Status '' not yet implemented, please submit an issue on GitHub

ghost commented 9 years ago

Definitely. Btw @KrauseFx - the language codes have been updated in your new readme I see (here: https://github.com/KrauseFx/deliver/blob/feature/spaceship/README.md). However, I see some are missing from the old one - including id and zh-Hant. I have no problem uploading screenshots for those though, so they might just be missing from the documentation. :)

artuan commented 9 years ago

@DeadCounter same for me when I tried to init the deliver.

ghost commented 9 years ago

@artuan - Yes comment it out for now (I did at least, and it works), @KrauseFx might suggest otherwise, but as far as I can read, the "version" has basically been automated in the new beta Deliver.

artuan commented 9 years ago

:/

/Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.18.0/lib/fastlane_core/configuration/configuration_file.rb:15:in `eval': Could not find option 'apple_id'
ghost commented 9 years ago

Remove or comment out apple_id as well

artuan commented 9 years ago

@DeadCounter thank you.. It got through but stopped @ cmn-Hant isn't an activated language.

I will wait for the update.

ghost commented 9 years ago

I used the cmn-Hant and cmn-Hans as well before the update, now I use zh-Hant and zh-Hans instead. Try those instead - they target Chinese Simplified (Hans) and Traditional (Hant).

dral3x commented 9 years ago

apple_id has been replaced by app

Don't know you but I also need to add app_identifier to my Deliverfile (app bundle id)

ghost commented 9 years ago

Nice @dral3x - didn't realise that, figured it was lacking as well so far. I've just been typing it in the command line as I ran deliver. :)

dral3x commented 9 years ago

I'm preparing a "short" post on my blog with all the main changes to do in order to migrate easily to the new deliver beta

ghost commented 9 years ago

nice touch @dral3x :)

dral3x commented 9 years ago

Any idea on how to use submission_information ? Before it was like this

submit_further_information({
  export_compliance: {
    export_compliance_encryption_updated: false,
    cryptography_enabled: false,
    is_exempt: false
  },
  third_party_content: {
    content_rights_contains_third_party_content: false,
    content_rights_has_rights: false
  },
  advertising_identifier: {
    add_id_info_uses_idfa: false
    add_id_info_serves_ads: false,
    attribute_advertisement: false,
    attribute_actions: false,
    limit_ad_tracking: false
  }
})

Thanks

mgamber commented 9 years ago

@KrauseFx So far so good with beta3, One minor critique; I actually use the "Food & Drink" category quite a bit and it's not on your list. I can hack it by putting "MZGenre.Apps.Food_Drink" in the category file and that does work but it would be nice if it were abstracted and added to your list. Otherwise it all looks good from here and the speed at which it's updated on Apple's end is very, very nice.

Thanks for your hard work! Looking forward to the final result!

ericertl commented 9 years ago

I stubled into this with the app rating

/Library/Ruby/Gems/2.0.0/gems/spaceship-0.10.1/lib/spaceship/tunes/app_version.rb:232:in `update_rating': Must be a hash (RuntimeError)
    from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta3/lib/deliver/upload_metadata.rb:140:in `set_app_rating'

I saw the new list of app rating names in https://github.com/KrauseFx/deliver/blob/feature/spaceship/Reference.md but I'm not sure how to use them. I changed my ratings json files in a couple of different ways, without any luck. I also spotted in https://github.com/fastlane/spaceship/blob/master/lib/spaceship/tunes/app_version.rb a couple of missing app rating names, like UNRESTRICTED_WEB_ACCESS, GAMBLING_CONTESTS and MATURE_SUGGESTIVE

Has anyone found out how to set up the ratings json file?

dral3x commented 9 years ago

@ericertl the new rating config is like this

{
"CARTOON_FANTASY_VIOLENCE" : 0,
"REALISTIC_VIOLENCE" : 0,
"PROLONGED_GRAPHIC_SADISTIC_REALISTIC_VIOLENCE" : 0,
"PROFANITY_CRUDE_HUMOR" : 0,
"MATURE_SUGGESTIVE" : 0,
"HORROR" : 0,
"MEDICAL_TREATMENT_INFO" : 0,
"ALCOHOL_TOBACCO_DRUGS" : 0,
"GAMBLING" : 0,
"SEXUAL_CONTENT_NUDITY" : 0,
"GRAPHIC_SEXUAL_CONTENT_NUDITY" : 0,
"UNRESTRICTED_WEB_ACCESS" : 0,
"GAMBLING_CONTESTS" : 0
}
mgamber commented 9 years ago

@dral3x Thanks for that.

ericertl commented 9 years ago

Thanks @dral3x . I'll try it now.

Did you find out how to send the submission_information ?

dral3x commented 9 years ago

I discovered a couple of problems doing a full submission of an app update.

After the new version is created, the deliver failed saying that there are not version editable. If I re-launch the script later on, it works.

[15:56:58]: [SHELL COMMAND]: deliver --force --submit_for_review
[15:57:01]: [SHELL]: [15:56:59]: Login to iTunes Connect (removed)
[15:57:01]: [SHELL]: [15:57:00]: Login successful
[15:57:07]: [SHELL]: [15:57:01]: Making sure the latest version on iTunes Connect matches '1.5.4' from the ipa file...
[15:57:07]: [SHELL]: [15:57:07]: Successfully set the version to '1.5.4'
[15:57:07]: [SHELL]: /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/lib/deliver/upload_metadata.rb:65:in `verify_available_languages!': Could not find a version to edit for app 'app-name', the app metadata is read-only currently (RuntimeError)
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/lib/deliver/upload_metadata.rb:18:in `upload'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/lib/deliver/runner.rb:52:in `upload_metadata'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/lib/deliver/runner.rb:19:in `run'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/lib/deliver/commands_generator.rb:47:in `block (2 levels) in run'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/lib/deliver/commands_generator.rb:84:in `run'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/lib/deliver/commands_generator.rb:12:in `start'
[15:57:07]: [SHELL]: from /usr/local/lib/ruby/gems/2.2.0/gems/deliver-1.0.0.beta3/bin/deliver:5:in `<top (required)>'
[15:57:07]: [SHELL]: from /usr/local/bin/deliver:23:in `load'
[15:57:07]: [SHELL]: from /usr/local/bin/deliver:23:in `<main>'

I also notice that the "submit for review" does not work. It reports it did, but in fact it does not.

[14:23:45]: [SHELL]: [14:23:35]: Finished the upload to iTunes Connect
[14:23:45]: [SHELL]: [14:23:35]: Selecting the latest build...
[14:23:45]: [SHELL]: [14:23:37]: Selecting build 1.5.3 (3703)...
[14:23:45]: [SHELL]: [14:23:38]: Successfully selected build
[14:23:45]: [SHELL]: [14:23:38]: Submitting the app for review...
[14:23:45]: [SHELL]: [14:23:45]: Successfully submitted the app for review!

The app still in "Prepare for Submission". Also it seams not wait until the build is processed and ready to be selected. Any feedback about these? Does them works for you guys?

Edit: with another app, the script is waiting for the build to be processed by Apple correctly. Strange

artuan commented 9 years ago

@DeadCounter I will try the language change for ch... thanks!

Are there any kind of step by step guide already available?

artuan commented 9 years ago

In the middle of upload:

/Library/Ruby/Gems/2.0.0/gems/spaceship-0.10.1/lib/spaceship/client.rb:244:in `parse_response': {"data"=>nil, "messages"=>{"warn"=>nil, "error"=>["Unauthorized access"], "info"=>nil}, "statusCode"=>"ERROR"} (Spaceship::Client::UnexpectedResponse)

Timeout? I have 24 languages...

dral3x commented 9 years ago

@ericertl still no luck on submission_information. It seams the main 3 questions have hardcoded value inside deliver. There is an "override" but I think it does not override what I want.

All the questions are mapped inside spaceship btw.

Maybe @KrauseFx can give us a hint also on that :rocket:

dral3x commented 9 years ago

This is the post I was announcing before.

http://www.alessandrocalzavara.com/blog/2015/09/29/fastlane-vs-itc/

KrauseFx commented 9 years ago

Wow, my time zone is really bad for answering your questions. So, good morning everybody.

@dral3x

If a version is approved cannot be edited anymore, so I suppose it uses the first editable version That's correct. deliver will just use the latest version it can edit. If you provide an ipa file, the version will be fetched from it and used to create a new version on iTC if necessary.

@artuan Did you read the release notes?

screenshot 2015-09-29 09 55 51

I tried to make it clear on what options are now deprecated.

@dral3x You don't need apple_id any more, it's enough to provide an app identifier. @dral3x

I'm preparing a "short" post on my blog with all the main changes to do in order to migrate easily to the new deliver beta I will write an migration guide to 1.0 and add it to this repo.

@mgamber

I actually use the "Food & Drink" category quite a bit and it's not on your list. I can hack it by putting "MZGenre.Apps.Food_Drink" in the category file and that does work but it would be nice if it were abstracted and added to your list. Interesting, why is the category missing in the Reference.md? Did I miss something?

@ericertl All documentation is in Deliverfile.md. @ericertl Submission information: https://github.com/KrauseFx/deliver/blob/feature/spaceship/Deliverfile.md#submission_information

@artuan this looks like a server issues on Apple's side. Not much I can do I think.

@dral3x The submission info are all just default values and can be overwritten. Can you share your configuration and let me know what you want to do?

Sorry for the late reply, but I had to sleep sometime :sleeping:

KrauseFx commented 9 years ago

@dral3x Great blog post.

That means that Apple broke all the fastlane things out there! How dare you, Apple!?

That's not entirely true. It only broke deliver, pilot and spaceship, all other tools keep working.

apple_id has been replaced by app

You really don't have to bother with apple_id or app, the app identifier is enough.

We need to provide the app bundle id now. Not sure why this is not coming from the ipa directly

I can do that, thanks :+1:

Your blog post is great, there is not much left I have to do :smile:

mgamber commented 9 years ago

@KrauseFx "I actually use the "Food & Drink" category quite a bit and it's not on your list. I can hack it by putting "MZGenre.Apps.Food_Drink" in the category file and that does work but it would be nice if it were abstracted and added to your list. Interesting, why is the category missing in the Reference.md? Did I miss something?"

That's what I'm asking...did you miss something? "Food & Drinks" is still on iTC and, as I mentioned, I can set it in iTC by putting "MZGenre.Apps.Food_Drink" in the category file (primary or secondary) but I don't see it on your list. Also, while I'm thinking of it, I noticed that setting a category to "Lifestyle" (for example) indeed sets the iTC item to "Lifestyle". When I do a "deliver init" to download the data from iTC, however, it shows up in the category file as "MZGenre.Lifestyle".

KrauseFx commented 9 years ago

@mgamber deliver is smart enough to support both MZGenre.Lifestyle and Lifestyle.

mgamber commented 9 years ago

@KrauseFx I'm just bringing it up because I have select boxes that use your reference list as the option values. If you select "Lifestyle" from the select box, it gets "Lifestyle" from the option value and that's what is put in the category file. If you download everything again, however, for whatever reason, it'll come back as "MZGenre.Lifestyle" which is NOT a value in the select option and, therefore, nothing is selected when the page is displayed. Also, since "Food & Drink" is "MZGenre.Apps.Food_Drink" it's apparently not as simple as just putting "MZGenre" in front of all the items in your reference. Could you possibly provide a list of the "MZGenre" items along with what you have in your reference now?

Sorry to keep harping on this, I'm just trying to find a way to normalize the data so looks the same coming and going from and to iTC.

KrauseFx commented 9 years ago

@mgamber I think I found the correct list:

["MZGenre.Book", "MZGenre.Business", "MZGenre.Apps.Catalogs", "MZGenre.Education", "MZGenre.Entertainment", "MZGenre.Finance", "MZGenre.Apps.Food_Drink", "MZGenre.Games", "MZGenre.Healthcare_Fitness", "MZGenre.Lifestyle", "MZGenre.Medical", "MZGenre.Music", "MZGenre.Navigation", "MZGenre.News", "MZGenre.Apps.Newsstand", "MZGenre.Photography", "MZGenre.Productivity", "MZGenre.Reference", "MZGenre.SocialNetworking", "MZGenre.Sports", "MZGenre.Travel", "MZGenre.Utilities", "MZGenre.Weather"]
mgamber commented 9 years ago

@KrauseFx Excellent, that's what I was looking for. Thanks!!

Both above and below. :-)

KrauseFx commented 9 years ago

@mgamber here we go: https://github.com/KrauseFx/deliver/blob/feature/spaceship/Reference.md

KrauseFx commented 9 years ago

@dral3x You'll be happy to see, the new version will automatically fetch the app identifier from the ipa file if given: https://github.com/KrauseFx/deliver/commit/188071c2552b91c299958437b09362918c1ab929

I'd still recommend storing the app identifier in the Appfile or Deliverfile so that everything works without an ipa file too.

KrauseFx commented 9 years ago

Hey everyone, I just finished up writing the migration guide: https://github.com/KrauseFx/deliver/blob/feature/spaceship/MigrationGuide.md

Let me know what you think. Also, I updated the Deliverfile documentation :rocket:

KrauseFx commented 9 years ago

The fastlane integration is almost ready, I'll push the first public 1.0 release soon. All the things that didn't make it into 1.0 are now listed here.

KrauseFx commented 9 years ago

I just pushed deliver 1.0.0 and fastlane 1.30.0. Please update using sudo gem update fastlane and let me know if everything works for you. Also, make sure to follow the new Migration Guide to 1.0 :rocket:

jacao commented 9 years ago

@KrauseFx Is it necessary to update deliver to 1.0.0 and migrate when using fastlane 1.30.0?

Could this cause the following error?

/Library/Ruby/Gems/2.0.0/gems/fastlane-1.30.1/lib/fastlane/actions/produce.rb:18:in `chdir': No such file or directory - ./fastlane/ (Errno::ENOENT)
fatuhoku commented 9 years ago

I'm getting the same error, but from cert:

~/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-1.30.1/lib/fastlane/actions/cert.rb:18:in `chdir': No such file or directory @ dir_chdir - ./fastlane/ (Errno::ENOENT)

This appears to be happening randomly.

jacao commented 9 years ago

I am also getting it for cert sometimes:

/Library/Ruby/Gems/2.0.0/gems/fastlane-1.30.1/lib/fastlane/actions/produce.rb:18:in `chdir': No such file or directory - ./fastlane/ (Errno::ENOENT)

Prior to this I get the following:

/Library/Ruby/Gems/2.0.0/gems/credentials_manager-0.8.2/lib/credentials_manager/appfile_config.rb:31: warning: conflicting chdir during another chdir block
fatuhoku commented 9 years ago

Related: KrauseFx/fastlane#643

GEC-it commented 9 years ago

Hi, found this issue: /Library/Ruby/Gems/2.0.0/gems/spaceship-0.10.1/lib/spaceship/tunes/tunes_client.rb:147:in `handle_itc_response': In order to save your changes, all s must be a .jpeg, .jpg, or .png file that is @@DIMENSION_VALUE@@ pixels, at least 72 DPI, and in the RGB color space. There are one or more errors on the page. (Spaceship::TunesClient::ITunesConnectError)

on the same set of screenshots yesterday was working fine.

KrauseFx commented 9 years ago

@jacao @fatuhoku This issue is caused by the release yesterday which had a race condition in fastlane_core. Could you please update using sudo gem update fastlane_core and let me know if this fixes your issue.

@cbo1964 

In order to save your changes, all s must be a .jpeg, .jpg, or .png file that is @@DIMENSION_VALUE@@ pixels, at least 72 DPI, and in the RGB color space

Where do you have the screenshots from? Were they downloaded by deliver init or deliver download_screenshots? What happens when you try to manually upload them to iTunes Connect?

fatuhoku commented 9 years ago

@KrauseFx I can confirm that the fix has worked =] :+1: Thanks so much for your hard work in the last few weeks!

KrauseFx commented 9 years ago

I think this issue is ready to be closed. Thanks again everybody for helping me with testing the new release :rocket:

dral3x commented 9 years ago

I can agree with you @KrauseFx. We should address single issues one by one :)

Thank you (and other guys) for all your hard work! :rocket:

mashour commented 9 years ago

Thanks Felix for closing this in such a short amount of time! Great job!

On Tue, Oct 6, 2015 at 5:01 PM, Felix Krause notifications@github.com wrote:

Closed #337 https://github.com/KrauseFx/deliver/issues/337.

— Reply to this email directly or view it on GitHub https://github.com/KrauseFx/deliver/issues/337#event-428054517.

Regards, Mostafa Ashour Managing Partner http://www.tryvin.com

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2224. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: