fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command
https://fastlane.tools
2.24k stars 162 forks source link

Error feedback when build number is incorrect. #519

Closed Remyoman closed 8 years ago

Remyoman commented 8 years ago

After I ran deliver through fastlane I got the following error:

NameError: undefined local variable or method 'data' for #<FastlaneCore::IpaUploadPackageBuilder:0x007fe0d9b93bd0>

After manually exporting my archive and trying to upload it, Xcode came with the error that the build number was incorrect. This was caused by my set_build_number_repository line. I didn't know the build numbers for iTunes Connect uploaded versions can't compose of an arbitray string, besides it needing to differ per submit.

It would be nice to improve the feedback for this particular case as it was quite confusing to find. The lane I used as reference (app-specific information renamed):

desc "Deploy a new version to the App Store"
  lane :deploy do
    snapshot
    cert
    produce(
        username: "user@name.com",
        app_identifier: "app.identifier",
        app_name: "AppName",
        language: "Dutch",
        sku: "app-sku",
    )

    sigh(force: true)
    set_build_number_repository

    gym(
        scheme: "AppName",
        clean: true
    ) # Build your app - more options available
    deliver(submit_for_review: false,
        automatic_release: false)

    clean_build_artifacts
    commit_version_bump(message: "Uploaded new version to AppStore")
    # frameit
  end
KrauseFx commented 8 years ago

Can you update to the latest version and also update fastlane_core using gem update fastlane_core?

KrauseFx commented 8 years ago

If that doesn't work, please share your complete output when running deliver

Remyoman commented 8 years ago

@KrauseFx I have just submitted it manually, but I will run it again to provide the output after updating as well. Thank you for the fast response.

Remyoman commented 8 years ago

@KrauseFx After updating my gems the Xcode output comes through. The transporter mentions the errors as can be seen in Xcode. I will follow the readme for making the gems directory writable again, as it seems to fail for me. Which would have prevented this issue.

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2132. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: