Apple TV Support: - Githubissues

fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command

https://fastlane.tools

2.24k stars 162 forks source link

Apple TV Support: #521

Closed samrobbins closed 8 years ago

samrobbins commented 8 years ago

Stores appletvos screen shots in a subdirectory.
Detects appletvos screen files correctly.
Update help text to include appleTV instructions.

samrobbins commented 8 years ago

This requires a commit in spaceship to function correctly. https://github.com/fastlane/spaceship/commit/f17033e49f8a66f88fbeadf3c4e4b2cda1c636c3

samrobbins commented 8 years ago

It is expected that CI will break as spaceship was not deployed yet with my changes.

KrauseFx commented 8 years ago

@samrobbins You can deploy the new version of spaceship and update the spaceship dependency of deliver :rocket:

samrobbins commented 8 years ago

@KrauseFx this is green now :balloon:

KrauseFx commented 8 years ago

This looks great already @samrobbins, hard problem - great solution. Could you also update the documentation to explain where the tv screenshots should be stored?

Does deliver init automatically create the folder + the tv screenshots?

samrobbins commented 8 years ago

@KrauseFx deliver init does the correct thing with existing screenshots. Let me test with no screenshots.

samrobbins commented 8 years ago

If no screenshots are available to download no appleTV folder is created. Should we try to auto detect this and create it? Saying that a project is tvOS only is hard since it could be a multi target project. Is updating the documentation good enough here?

samrobbins commented 8 years ago

@KrauseFx ( added to concat call as well.

KrauseFx commented 8 years ago

LGTM, testing it on some real-world project before it's ready to be merged :+1:

KrauseFx commented 8 years ago

Looks great, :ship: