search

fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command
https://fastlane.tools
2.24k stars 162 forks source link

Deliver exits with code 0 when there are Transporter errors #522

Closed igoris closed 8 years ago

igoris commented 8 years ago

I see the following in the log:

[14:13:24]: [Transporter Error Output]: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 7.0."
[14:13:24]: [Transporter]: DBG-X: The error code is: 1102
[14:13:24]: [Transporter]: INFO: Done performing authentication.
[14:13:24]: Transporter transfer failed.
[14:13:24]: 
[14:13:24]: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 7.0."
[14:13:24]: Return status of iTunes Transporter was 1: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 7.0."
[14:13:24]: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 7.0."
Return status of iTunes Transporter was 1: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 7.0."
[14:13:24]: Finished the upload to iTunes Connect

However, echo $? returns 0

Instead, deliver should have non-zero return code to indicate an error.

deliver version 1.6.5 command is deliver --ipa "release.ipa" --skip_screenshots --skip_metadata --force

rodja commented 8 years ago

Until this is fixed, I'll use this workaround:

$ deliver --ipa "release.ipa" --skip_screenshots --skip_metadata --force | tee deliver.log
$ grep deliver.log "ERROR" && exit 1
danieljimenez commented 8 years ago

I'm running into the same issue with it exiting 0. We use TeamCity so we added a failure condition looking for the string ERROR

KrauseFx commented 8 years ago

@igoris did I understand correctly that deliver doesn't proper fail with an exit code when the iTunes Transporter had an issue? Can you share the complete output when running deliver? Is there any stack trace?

danieljimenez commented 8 years ago

In my case the output looks like this:

[14:53:27]: [Transporter Error Output]: ERROR ITMS-90023: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '167x167' pixels, in .png format ."

[14:53:27]: [Transporter]: DBG-X: The error code is: 1102
[14:53:27]: [Transporter]: INFO: Done performing authentication.
[14:53:27]: Transporter transfer failed.
[14:53:27]: 
[14:53:27]: ERROR ITMS-90023: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '167x167' pixels, in .png format ."

[14:53:27]: Return status of iTunes Transporter was 1: ERROR ITMS-90023: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '167x167' pixels, in .png format ."

[14:53:27]: ERROR ITMS-90023: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '167x167' pixels, in .png format ."
Return status of iTunes Transporter was 1: ERROR ITMS-90023: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '167x167' pixels, in .png format ."

[14:53:27]: Password contains special characters, which may not be handled properly by iTMSTransporter. If you experience problems uploading to iTunes Connect, please consider changing your password to something with only alphanumeric characters.
[14:53:27]: Could not download/upload from iTunes Connect! It's probably related to your password or your internet connection.
[14:53:27]: Finished the upload to iTunes Connect
KrauseFx commented 8 years ago

Perfect, thank you @danieljimenez

KrauseFx commented 8 years ago

Thanks everyone, this will be fixed with the next release https://github.com/fastlane/deliver/pull/592 :+1:

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2131. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: