fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command
https://fastlane.tools
2.24k stars 162 forks source link

Screenshots not found for uppercase extensions like .PNG #531

Closed din closed 8 years ago

din commented 8 years ago

I am running deliver init which automatically downloads existing screenshots from iTC, and then I am running deliver and cannot see the screenshots in the Preview.html. I found out that all the screenshots downloaded by the app are named *.PNG and after I renamed them manually to *.png they were successfully detected.

Is this a bug, or a known behaviour?

alper commented 8 years ago

You're a lifesaver. I couldn't figure out why it wasn't finding any screenshots. This should definitely be fixed.

mfurtak commented 8 years ago

Hi @din - Can you run this command and give me the output?

diskutil info / | grep 'Personality'

Thanks! :+1:

din commented 8 years ago

Sure.

File System Personality: Journaled HFS+

mfurtak commented 8 years ago

Got it - totally normal! :icecream:

Still digging in...

mfurtak commented 8 years ago

OK, we have tracked this down. It's actually affected by what Ruby version you are running! 😨Are you running Ruby 2.1.x or earlier?

In any case, a fix should be coming soon! :tada:

din commented 8 years ago

I am running a default OS X version for OS X 10.11.2, which is:

$ ruby -v
ruby 2.0.0p645 (2015-04-13 revision 50299) [universal.x86_64-darwin15]

Thank you for fixing it!

mfurtak commented 8 years ago

This will go out in the next release of deliver - thanks for the report :rocket:

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2128. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: