Exit with non-zero status if binary upload failed

fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command

https://fastlane.tools

2.24k stars 162 forks source link

Closed henriquegemignani closed 8 years ago

henriquegemignani commented 8 years ago

Currently, fastlane only prints to the log file if the binary upload failed, hiding this information from callers unless they parse the text output.

An ugly side effect of the current code would be to submit an app for review with the old binary.

KrauseFx commented 8 years ago

Very good point, thanks for the PR. I added one comment. Could you update this and squash everything to one commit? Thanks :+1:

asfalcone commented 8 years ago

@henriquegemignani Sorry for the delay on this PR! We'd still like to merge this if you're able to make 2 adjustments!

1) Please rebase on master since there are no conflicts 2) Please use UI.user_error! instead of abort

Thanks!

asfalcone commented 8 years ago

@henriquegemignani Thanks again for the PR! 🚀

KrauseFx commented 8 years ago

This commit had to be reverted with https://github.com/fastlane/fastlane/pull/3790. @henriquegemignani Could you clarify what you initially wanted to do with this PR?