* add option for deliver a specific existing build

[hjanuschka]

allows deliver to select a specific/existing build number instead of uploading current build binary.

sample:

deliver(
    build_number: "666",
    force: true,
    skip_metadata: true,
    skip_screenshots: true,
    submit_for_review: true
)

to use the latest (already uploaded build on Tunes) - set build_number to latest

[KrauseFx]

Hey @hjanuschka, thanks for this PR. I really like the idea of submitting existing builds for Review, however I think this change adds quite some complexity.

How about we design it as following:

deliver submit_build --build_number 830 --version_number 1.4

while both values are optional.

This command would then only submit the build for review and not upload anything: no metadata, no screenshots and no builds.

What do you think?

[hjanuschka]

thx for the review.

• removed the unused option (has been left from another atempt to solve my problem)
• i like the idea of having a standalone action (like in match, the nuke actions)
  • the proposal looks nice, without the version/build parameters the latest will be submitted.

but to be honest, i don't think it ads too much complexity - because it is one parameter, and only if set, just selects a specific build instead of waiting for the upload build.

i think there is room for a use-case where one selects a specific build but also updates screenshots,metadata,releasenots and so on.

[hjanuschka]

@KrauseFx ok rebased the PR - the command

./deliver submit_build —build_number 199 should now work. (there is no usecase for version flag, because i think you can only have one open version train per platform)

and my original implementation also works. :beers:

[hjanuschka]

• rebased current master wich has skip_upload option

@KrauseFx

[hjanuschka]

thx @lacostej about the wrong .find() fixed now

[hjanuschka]

@KrauseFx any chances for a review

[KrauseFx]

Reviewing this now. I'd also like the confirmation from @jaleksynas, as he wanted this feature :+1:

[jaleksynas]

I like this feature for certain! it is critical when using decoupled pilot/testflight operations.

As a standalone command does this still work inside the fastlane deliver action as shown at the top of the PR?

My intention is to have a lane that builds, uploads and sends to testing using pilot. (Continuously)

The a user will run a release lane to simply 'deliver' the latest meta-data, screenshots and submit the latest build for review once we bless the latest TestFlight build. I like the meta-data/screenshots to be part of this deliver step because often this content is being updated during testing with testflight.

[hjanuschka]

@jaleksynas like your feedback, thx - going to work on this PR tonight. the feature works as you described - we have exact the same workflow - and it will work from fastfile and from standalone commandline

[hjanuschka]

ok feedback implemented

• if no build_number specified, in commandline version only, "latest" will be used!
  • eg.: deliver submit_build --skip_metadata --skip_screenshots --force selects latest iTC build number and submits that for review!
• rebased current master
• added README entry
• removed all fixed options from command_runner, except the "submit_for_review" the other should work like on all other deliver calls

@KrauseFx if no build is found an exception is raised, if build_number is not latest.

12:30:00]: Activating language de-DE...
[12:30:03]: Uploading metadata to iTunes Connect
[12:30:04]: Successfully uploaded initial set of metadata to iTunes Connect
[12:30:05]: Starting with the upload of screenshots...
[12:30:05]: Successfully uploaded screenshots to iTunes Connect
[12:30:08]: Finished the upload to iTunes Connect
[12:30:09]: Selecting existing build-number: 199
/Users/hja/Desktop/SPORTPORTAL/deliver/lib/deliver/submit_for_review.rb:40:in `select_build': Build number: 199 does not exist (RuntimeError)
    from /Users/hja/Desktop/SPORTPORTAL/deliver/lib/deliver/submit_for_review.rb:5:in `submit!'

so for now you can do via commandline:

deliver submit_build --build_number 199 --force --skip_metadata # if you want to skip metadata for example

via fastfile it will look like this:

deliver(
     build_number: 199,
    force: true,
    skip_metadata: false
)

if no skip param is set, metadata, screenshots and so on will be updated, so i hope this fits your workflow @jaleksynas (we pretty much have the same)

@KrauseFx - mind if you review again?

[KrauseFx]

Hey @hjanuschka, this is great, thank you so much for updating the PR, this looks good already. I added some comments - also it seems like there is a merge conflict.

Thank you so much for all your ongoing contribution and help, really appreciated :tada: :rocket: :sparkles: (3 emojis!)

[hjanuschka]

thx for the review - and for the three emojis!

• master rebased
• changed raise and helper.log to UI stuff
• implemented your suggestions (except the one with the default_value in the commander part, commented on it https://github.com/fastlane/deliver/pull/548#discussion_r52057354)

• rubocop good, tests pass and no hound woof!

  hope we are ready to merge soon ;)

ping @KrauseFx

[KrauseFx]

Perfect, thank you again for updating the PR and working in the last changes. This will be in the next release :+1: