deliver doesn't remove screenshots

fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command

https://fastlane.tools

2.24k stars 162 forks source link

deliver doesn't remove screenshots #550

Closed lacostej closed 8 years ago

lacostej commented 8 years ago

run deliver to upload some screenshots (e.g. 5)
remove some from disk
re-run deliver

expected: removed screenshots on disk are removed from ITC

what happens: removed screenshots are not removed from ITC

lacostej commented 8 years ago

Current (spaceship based) work-around:

Spaceship.login(user, password)
Spaceship::Tunes.login(user, password)
du = Spaceship::Tunes.client.du_client

app = Spaceship::Tunes::Application.find bundle_id

appv = app.edit_version

appv.screenshots.each do |language, screenshots|
  screenshots.each do |sc|
    appv.upload_screenshot!(nil, sc.sort_order, sc.language, sc.device_type)
  end
end

appv.save!

markusfassbender commented 8 years ago

i've got the same issue. we had 5 screenshots online and now i changed the project to use fastlane (thank your for the great work) with snapshot that creates 4 screenshots. the last screenshot in itunesconnect is not removed. i do not use spaceship until now, is there any other solution?

thanks

KrauseFx commented 8 years ago

So deliver should delete the screenshots when there is at least one for this language/device. We don't want to remove existing screenshots if there are no new ones there.

markusfassbender commented 8 years ago

this is the right way in my opinion :+1:

ZackaryVink commented 8 years ago

I am seeing this same issue. When I push 3 images (and there are already 4 on ITC), the three new images get put up but one of the old screenshots is still there.

armadsen commented 8 years ago

Seeing this too. My app was rejected for a problem with one screenshot. Being able to delete just that one by deleting it for all devices sizes and all localizations on disk then re-running deliver would be very useful, but it's not working.

jeffreyjackson commented 8 years ago

is it possible to delete all screenshots on iTC before upload? deliver is only filling in the blanks, and i need to redo all screenshots completely.

lacostej commented 8 years ago

@jeffreyjackson right now it's not possible. I hope to be able to make deliver sync the local directory with the remote ITC in the future. Right now, the simplest way I know to remove all screenshots is to use the spaceship script that I posted earlier in that issue.

jeffreyjackson commented 8 years ago

@lacostej do you know offhand if spaceship will need iTC credentials each time? I'm looking to build this into a CI routine.

jeffreyjackson commented 8 years ago

@KrauseFx any suggestions for this? maybe i can rally for a PR.

jeffreyjackson commented 8 years ago

I think this feature would also inherently fix #597

fastlane-bot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/1529. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: