search

fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command
https://fastlane.tools
2.24k stars 162 forks source link

The custom metadata_path is not being used with download_metadata #558

Closed lozhuf closed 8 years ago

lozhuf commented 8 years ago

When using the following command: deliver download_metadata -m "./fastlane/Test/metadata" ... the specified custom metadata path is not used (the same if it is defined in the deliverfile) The output is (confusingly) as follows:

+-------------------+--------------------------+
|            deliver 1.8.1 Summary             |
+-------------------+--------------------------+
...
| metadata_path     | ./fastlane/Test/metadata |
...
+-------------------+--------------------------+

Do you want to overwrite existing metadata on path '/Users/<project_path>/fastlane/metadata'? (y/n)

This seems to be related, if not the same, as issue #475 ... perhaps the merged fix didnt catch the download_metadata case?

muZZkat commented 8 years ago

+1

KrauseFx commented 8 years ago

Agreed, this should be fixed, however this PR https://github.com/fastlane/deliver/pull/481 broke a lot of things and had to be rolled back.

KrauseFx commented 8 years ago

Closed with https://github.com/fastlane/deliver/issues/567

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2119. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: