fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command
https://fastlane.tools
2.24k stars 162 forks source link

Support a 'default' locale folder for fall-back values #561

Closed mfurtak closed 8 years ago

mfurtak commented 8 years ago

Users can specify a default which applies when there is no specific value for a given language.

name ({ "en_us" => "English name", "default" => "Default name"})

will have the same effect as

name ({ "en_us" => "English name", "fr_FR" => "Default name", "it" => "Default name", "ja" => "Default name"})

similarly, a user can create a metadata folder 'default' and put in something like release_notes.txt this will be used for all languages where there isn't an explicit release_notes.txt

languages are filled in if they are either 1) used in a setting explicitly in the deliverfile 2) there is a language folder (possibly empty) in the metadata folder

mfurtak commented 8 years ago

@ConfusedVorlon @KrauseFx This is a clean-up of #547 to:

ConfusedVorlon commented 8 years ago

@mfurtak you missed a line! Apologies for not spotting it when I checked this over - but it is a critical line to read defaults from the filesystem. I have sent a new pull request to fix this.