Fixing folder creation on downloads

[martinjuhasz]

Download commands should not create a screenshots or metadata folder if a custom path is used, something that i missed yesterday.

If you use the options screenshots_path or metadata_path for uploading, you specify the path directly pointing to the related directory, but if you set this for downloading it creates another screenshot/metadata directory inside.

The classes/methods for uploading take a path param and use this path without appending something. The download classes now do the same and the appending of the correct subfolder happens before calling it.

I think this is now the behavior that was intended?

[KrauseFx]

Why does this require so many changes when it's basically just fixing folder not there yet?

[martinjuhasz]

Its more about appending the screenshots and metadata folder if no custom path was set, than creating missing folders. generate_metadata_files and download_screenshots always appended these no matter if a custom download/metadata path was set or not. They no longer do this and "if a folder should be appended" logic moved to the command_generator, like it was done for uploading.

Current behavior, example dir:

project/
   metadata/
   screenshots/
      de-DE/
      en-US/

Upload Screenshots: deliver --skip_metadata --screenshots_path project/screenshots

But to download screenshots to the same directory: deliver download_screenshots --screenshots_path project

[martinjuhasz]

don't know why squashing is always such a hassle for me. anyway, fixed a typo and pushed again.

[asfalcone]

Thanks @martinjuhasz! :open_file_folder: :sparkles: