search

fastlane-old / deliver

Upload screenshots, metadata and your app to the App Store using a single command
https://fastlane.tools
2.24k stars 162 forks source link

Update to use latest fastlane_core and add a spec #577

Closed i2amsam closed 8 years ago

i2amsam commented 8 years ago

Fixes https://github.com/fastlane/deliver/issues/575 by bringing in the new fastlane_core which handles non-string error messages.

KrauseFx commented 8 years ago

Looks good to me, however not 100% sold on the introduced dependency :+1:

KrauseFx commented 8 years ago

Ready to merge from my side

i2amsam commented 8 years ago

Updated per @mfurtak and @asfalcone's suggestions on how to best avoid that dependency.

mfurtak commented 8 years ago

Looks good. :ship: it!

KrauseFx commented 8 years ago

Great, this makes me happy :+1: